-
Notifications
You must be signed in to change notification settings - Fork 193
add portuguese translation #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ig => Zig 😅
It should not be translated, otherwise it may uncharacterize it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! 😊
I think there is going to be a problem with loading pex-white.svg
and pex-black.svg
in content/_index.pt.md
(line 111 and 112) as they are static assets served at /
.
Thank you very much for contributing this translation! Awesome job translating all those pages, I still am lagging behind with the italian version :) I'll add a few comments, but first of all please pull from master so that you can get in sync. One important addition that you don't have access to right now is the ability to add Once you pull from master you'll be able to change it like so:
I'll also leave a couple comments in a moment. |
Okay! At the moment I'm not on the PC, but it's already synchronized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done reviewing, thank you again for the huge help.
If you have any questions please don't hesitate to ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I just suggested a couple of final fixes to some links.
We're at the end, I just need to ask you to be patient because I'm about to merge a fix for #99 which will add a few final lines to translate. I'll let you know when it is merged and how to do the translation.
After we're done with that I'll be ready to merge (no need for more reviews) :)
Thanks again!
Co-authored-by: Loris Cro <kappaloris@gmail.com>
Co-authored-by: Loris Cro <kappaloris@gmail.com>
Co-authored-by: Loris Cro <kappaloris@gmail.com>
Co-authored-by: Loris Cro <kappaloris@gmail.com>
Co-authored-by: Loris Cro <kappaloris@gmail.com>
Okay! I thank you for your patience, since translating languages from different vocabulary is not that easy. I encourage others who understand portuguese to consume and contribute to this project. |
There are 3 new variables in
WIth this we're done. Thank you again. |
@kassane let me know when you're ready to merge :) |
@kristoff-it , done! |
Thank you very much for your contribution! If you happen to drop by any of the Zig communities on Discord make sure to say hi! |
No description provided.