Make emulator hub locator path more robust to environment changes #8604
Conversation
Just tested it and it does cleanup, works same exact way as the previous one worked. |
The Not something that consumes a lot of resource, right? |
|
Can you take a look at this small but risky change? It sounds like some MCP client sets the |
| const dir = os.tmpdir(); | ||
| const filename = `hub-${projectId}.json`; | ||
| return path.join(dir, filename); | ||
| return path.join(os.homedir(), ".cache", "firebase", `hub-${projectId}.json`); |
There was a problem hiding this comment.
What if the parent directories do not exist? Can we find some existing code in the rest of the CLI code base that creates the parents and reuse the logic?
There was a problem hiding this comment.
I suspect this is why the integration tests are failing btw - the runner does not have this directory
Description
Some clients couldn't discover emulator due to tempdir path being different depending the client, by using ~/.cache/firebase we should have more robust path.
Scenarios Tested
Running dataconnect emulator
Running dataconnect MCP and communicating with emulator from previously failing client (RooCode)
Sample Commands