Make emulator hub locator path more robust to environment changes #8604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
requested changes
May 15, 2025
Just tested it and it does cleanup, works same exact way as the previous one worked. |
fredzqm
approved these changes
May 15, 2025
The Not something that consumes a lot of resource, right? |
fredzqm
requested changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some clients couldn't discover emulator due to tempdir path being different depending the client, by using ~/.cache/firebase we should have more robust path.
Scenarios Tested
Running dataconnect emulator
Running dataconnect MCP and communicating with emulator from previously failing client (RooCode)
Sample Commands