Add soft-delete support and set dag_version FK on delete to SET NULL #50922
+1,444
−1,291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
644ce09 to
0020deb
Compare
8e07a32 to
14a5876
Compare
uranusjr
reviewed
May 22, 2025
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
May 22, 2025
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
Lee-W
reviewed
May 22, 2025
airflow-core/src/airflow/migrations/versions/0071_3_1_0_add_is_active_to_dag_version.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Show resolved
Hide resolved
3ed69fc to
e6947f5
Compare
Lee-W
approved these changes
May 22, 2025
airflow-core/src/airflow/migrations/versions/0071_3_1_0_add_is_active_to_dag_version.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
Outdated
Show resolved
Hide resolved
445f8d9 to
8d042f3
Compare
uranusjr
reviewed
May 23, 2025
airflow-core/src/airflow/migrations/versions/0071_3_1_0_add_is_active_to_dag_version.py
Outdated
Show resolved
Hide resolved
|
This looks good, but I’m not sure we want to remove the cascade deletion. I feel it is fine if we do soft deletion; if the user really wants the record to be actually gone, the ti should be gone too. See discussion in linked issue. |
@uranusjr I have just added soft deletion and added back cascade deletion. Please re-review. But now that I think about it. Task instances are your single source of truth for what actually ran, when and with what outcome. If you delete the serialised-DAG (or its version), you wipe out every TaskInstance that pointed at it. That means no more execution history or retry state for those runs. Is this the right behaviour for the user? |
e7196d2 to
54a32bc
Compare
…te the column with prefilled values.
54a32bc to
eeee740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces soft-delete for DAG versions and changes the foreign-key behaviour on
task_instance.dag_version_idso that deleting a version no longer cascades, but instead sets the reference toNULL.closes: #49580
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.