Just do soft deletion

sunank200 · sunank200 · commit 54a32bc70df4 · 2025-05-23T13:13:13.000+05:45
diff --git a/airflow-core/docs/img/airflow_erd.sha256 b/airflow-core/docs/img/airflow_erd.sha256
@@ -1 +1 @@
-9ddb6fa4298bb5cf928ca4307ea1530815e008c4cfec80ab4b4a455417be3731
+1180c8d302c080e6c01ea4b2acac362365b89985366fd3fde368ea331e8854d4
diff --git a/airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py b/airflow-core/src/airflow/migrations/versions/0072_3_1_0_modify_taskinstance_dag_version_fk.py
@@ -50,6 +50,7 @@ def upgrade():
             "dag_version",
             ["dag_version_id"],
             ["id"],
+            ondelete="CASCADE",
         )
 
 
diff --git a/airflow-core/src/airflow/models/dag.py b/airflow-core/src/airflow/models/dag.py
@@ -1975,7 +1975,7 @@ class DagModel(Base):
     dag_versions = relationship(
         "DagVersion",
         back_populates="dag_model",
-        cascade="save-update, merge",
+        cascade="all, delete, delete-orphan",
         passive_deletes=True,
     )
 
diff --git a/airflow-core/src/airflow/models/taskinstance.py b/airflow-core/src/airflow/models/taskinstance.py
@@ -569,7 +569,7 @@ class TaskInstance(Base, LoggingMixin):
     _task_display_property_value = Column("task_display_name", String(2000), nullable=True)
     dag_version_id = Column(
         UUIDType(binary=False),
-        ForeignKey("dag_version.id"),
+        ForeignKey("dag_version.id", ondelete="CASCADE"),
         nullable=True,
     )
     dag_version = relationship("DagVersion", back_populates="task_instances")

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-9ddb6fa4298bb5cf928ca4307ea1530815e008c4cfec80ab4b4a455417be3731`
	`1`	`+1180c8d302c080e6c01ea4b2acac362365b89985366fd3fde368ea331e8854d4`
Original file line number	Diff line number	Diff line change
`@@ -1975,7 +1975,7 @@ class DagModel(Base):`
`1975`	`1975`	`dag_versions = relationship(`
`1976`	`1976`	`"DagVersion",`
`1977`	`1977`	`back_populates="dag_model",`
`1978`		`- cascade="save-update, merge",`
	`1978`	`+ cascade="all, delete, delete-orphan",`
`1979`	`1979`	`passive_deletes=True,`
`1980`	`1980`	`)`
`1981`	`1981`
Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ class TaskInstance(Base, LoggingMixin):`
`569`	`569`	`_task_display_property_value = Column("task_display_name", String(2000), nullable=True)`
`570`	`570`	`dag_version_id = Column(`
`571`	`571`	`UUIDType(binary=False),`
`572`		`- ForeignKey("dag_version.id"),`
	`572`	`+ ForeignKey("dag_version.id", ondelete="CASCADE"),`
`573`	`573`	`nullable=True,`
`574`	`574`	`)`
`575`	`575`	`dag_version = relationship("DagVersion", back_populates="task_instances")`