We have some CSS styling for the old Wikibase special pages. With the move to ooui this special CSS leads to orverly large margins in the forms. We should remove that CSS.
Before | After |
---|---|
Lydia_Pintscher | |
Mar 6 2017, 2:07 PM |
F6330523: before.png | |
Mar 8 2017, 12:13 PM |
F6330533: after.png | |
Mar 8 2017, 12:13 PM |
We have some CSS styling for the old Wikibase special pages. With the move to ooui this special CSS leads to orverly large margins in the forms. We should remove that CSS.
Before | After |
---|---|
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Remove excess bottom margin for special page input fields | mediawiki/extensions/Wikibase | master | +0 -1 |
I notice this issue yesterday...
ooui adds margin-top for each field:
margin-top: 1.171875em;
we also use wb-input css class which adds margin-bottom:
margin-bottom: 1em;
It might be work to remove the margin-bottom, if that's no longer needed anywhere or move that to a separate css class that is only used in places where it still needed
We should remove this margin. I don't believe it is needed any more. Everything switched to OOUI. If it is still needed somewhere we should fix these places later with much more specific CSS, not by simply adding a margin to a selector as generic as wb-input.
Change 341487 had a related patch set uploaded (by aude):
[mediawiki/extensions/Wikibase] Remove excess bottom margin for special page input fields
Change 341487 merged by jenkins-bot:
[mediawiki/extensions/Wikibase] Remove excess bottom margin for special page input fields
I chose to keep .wb-input in the patches for T48248 to avoid changing the layout too much but now I'm realizing that the huge wasted space was actually its fault...