fix: correctly invalidate static analysis cache of child nodes during dev #13793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltigerchino
commented
May 15, 2025
🦋 Changeset detectedLatest commit: 129c2bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
May 15, 2025
| @@ -387,10 +387,14 @@ export async function dev(vite, vite_config, svelte_config) { | |||
| } | |||
| }); | |||
|
|
|||
| // changing the svelte config requires restarting the dev server | |||
| // the config is only read on start and passed on to vite-plugin-svelte | |||
| // which needs up-to-date values to operate correctly | |||
| vite.watcher.on('change', async (file) => { | |||
There was a problem hiding this comment.
could you add a comment here and/or 30 lines above where we have watch('change', (file) => { ...? From a quick glance, I'm not sure what the difference is between them and why we need two file watchers
There was a problem hiding this comment.
Good idea. Found out these all use the same vite.watcher but watch only runs for certain files. The problem lies elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to add the static analysis cache invalidation to the Vite file change listener.Currently, if the page options of a parent node is updated during development, the child nodes incorrectly use the stale cached results instead of inheriting the new page options of the parent.This PR intends to ensure updating the page options in a layout during development updates the affected children too.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits