Skip to content

IterableOnce#copyToArray uses helper for count [ci: last-only] #10691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.13.x
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Feb 15, 2024

Don't throw (index out of bounds) when there is no runtime work (destination is zero length or count <= 0).

Audited implementations but did not boost the test coverage much.

Fixes scala/bug#12948

@scala-jenkins scala-jenkins added this to the 2.13.14 milestone Feb 15, 2024
@som-snytt som-snytt changed the title IterableOnce#copyToArray uses helper for count IterableOnce#copyToArray uses helper for count [ci: last-only] Feb 15, 2024
@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Feb 15, 2024
@SethTisue SethTisue modified the milestones: 2.13.14, 2.13.15 Mar 13, 2024
@som-snytt som-snytt closed this Mar 20, 2024
@SethTisue SethTisue removed this from the 2.13.15 milestone Mar 21, 2024
@som-snytt som-snytt reopened this Nov 9, 2024
@scala-jenkins scala-jenkins added this to the 2.13.16 milestone Nov 9, 2024
@SethTisue SethTisue modified the milestones: 2.13.16, 2.13.17 Dec 12, 2024
@som-snytt som-snytt force-pushed the issue/12948-copy-array branch from b4213ef to 8b57370 Compare May 12, 2025 16:27
@som-snytt som-snytt marked this pull request as ready for review May 12, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent copyToArray semantics between IterableOnceOps and Vector (and some other collections).
4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy