Skip to content

Update RpcQueryMessageFlow.java to fix the bug #276 #273 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update RpcQueryMessageFlow.java to fix the bug #276 #273 #287

wants to merge 1 commit into from

Conversation

adamgongca
Copy link

@adamgongca adamgongca commented Dec 21, 2023 •
edited
Loading

#276 #273

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

New Public APIs

Additional context

Signed-off-by: Adam Gong adam.gong.ca@gmail.com

@adamgongca
Update RpcQueryMessageFlow.java to fix the dug r2dbc#276 r2dbc#273
e41d301 
r2dbc#276 r2dbc#273 

Signed-off-by: Adam Gong <adam.gong.ca@gmail.com>
@adamgongca adamgongca changed the title Update RpcQueryMessageFlow.java to fix the dug #276 #273 Update RpcQueryMessageFlow.java to fix the bug #276 #273 Dec 21, 2023
@aironi
Copy link

aironi commented Apr 5, 2024 •
edited
Loading

What's the status of this PR? Will it fix the bug #273 and #276 ?

I am anxious for new version 1.0.3 to be released since we are forced to use 1.0.0 due to 1.0.2 not working. We still get #245 with 1.0.0 in certain cases but due to other bugs (#273 and #276) the 1.0.2 is not working and not usable to us.

@adamgongca
Copy link
Author

What's the status of this PR? Will it fix the bug #273 and #276 ?

I am anxious for new version 1.0.3 to be released since we are forced to use 1.0.0 due to 1.0.2 not working. We still get #245 with 1.0.0 in certain cases but due to other bugs (#273 and #276) the 1.0.2 is not working and not usable to us.

I'd like to submit the PR, but the system always tell me the comment existed some problem. I had to give up. if you still have problem, please take a look at my solutions, I recommend the second one. thanks.

@savuori
Copy link

savuori commented Apr 8, 2024

@adamgongca

The error is: "Commit sha: e41d301, Author: Adam Gong, Committer: GitHub; Expected "Adam Gong 43736198+adamgongca@users.noreply.github.com", but got "Adam Gong adam.gong.ca@gmail.com"."

Looks like you might be using your github private email when commiting but DCO expects the GPG signature's email and commiter emails to be the same.

https://docs.github.com/en/authentication/troubleshooting-commit-signature-verification/using-a-verified-email-address-in-your-gpg-key

You might be able to use git amend to change your commit's email to match the GPG identity's email address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamgongca @aironi @savuori
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy