Skip to content

Prevent load* methods outside of preload from rerunning setup #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

davepagurek
Copy link
Contributor

Resolves #5810

Changes:

  • Before user setup/draw methods are called, a flag is set indicating that the preload phase is done
  • After this point, load* methods will no longer increment/decrement preloads, and will no longer trigger setup getting run again

I've made an updated version of the p5 editor sketch from the issue, using a build with this new code. Previously, this would keep loading the shader again and again. Now, it just loads once: https://editor.p5js.org/davepagurek/sketches/4I3mDwb_u

PR Checklist

  • npm run lint passes
  • [Inline documentation] is included / updated
  • [Unit tests] are included / updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug when use callback in loadShader()
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy