TYP: annotate strings.slice
#29048
Merged
TYP: annotate strings.slice
#29048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if this could be smuggled into the 2.3 branch before the grand premiere :) |
jorenham
commented
May 25, 2025
|
|
||
| # | ||
| @overload | ||
| def slice(a: U_co, start: i_co | None = None, stop: i_co | None = None, step: i_co | None = None, /) -> NDArray[np.str_]: ... # type: ignore[overload-overlap] |
There was a problem hiding this comment.
I # type: ignore'd this mypy error because I believe that it's a false positive. This seems to be in line with what pyright believes, because it doesn't report an error here.
ea61465 to
89cf1fa
Compare
89cf1fa to
4c1eb70
Compare
|
Thanks Joren. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
numpy.strings.slicefunction (#27789) was missing from the typing stubs. So here it is.