TYP: Type MaskedArray.__{add,radd,sub,rsub}__
#29012
Open
+452
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
May 20, 2025
| @@ -368,3 +382,243 @@ assert_type(MAR_2d_f4.T, np.ma.MaskedArray[tuple[int, int], np.dtype[np.float32] | |||
|
|
|||
| assert_type(MAR_2d_f4.nonzero(), tuple[_Array1D[np.intp], *tuple[_Array1D[np.intp], ...]]) | |||
| assert_type(MAR_2d_f4.nonzero()[0], _Array1D[np.intp]) | |||
|
|
|||
| # Masked Array addition | |||
There was a problem hiding this comment.
from here below it's all the maskedarray analogoue to the tests in numpy/typing/tests/data/reveal/arithmetic.pyi
There was a problem hiding this comment.
Then a classic # Keep in sync with ... might be helpful here
jorenham
reviewed
May 20, 2025
| @@ -368,3 +382,243 @@ assert_type(MAR_2d_f4.T, np.ma.MaskedArray[tuple[int, int], np.dtype[np.float32] | |||
|
|
|||
| assert_type(MAR_2d_f4.nonzero(), tuple[_Array1D[np.intp], *tuple[_Array1D[np.intp], ...]]) | |||
| assert_type(MAR_2d_f4.nonzero()[0], _Array1D[np.intp]) | |||
|
|
|||
| # Masked Array addition | |||
There was a problem hiding this comment.
Then a classic # Keep in sync with ... might be helpful here
| def __sub__(self, other): ... | ||
| def __rsub__(self, other): ... | ||
|
|
||
| # Keep in sync with `ndarray.__add__` |
There was a problem hiding this comment.
it might also be a good idea to mirror these comments on ndarray side in __init__.pyi then
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.