-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
MAINT: remove references to 256-bits extended precision types #28932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we can safely assume that these will never exist, I think.
EDIT: For clarity, these are currently only relevant for us as aliases to a native C type (i.e. long long
). An int256_t
could exist of course, but would be different.
(including float80 there seems also right. Not sure that ever exists either, it exists elsewhere in our source...)
I don't think the 80-bit ones can exist in python, but perhaps they can in C? |
Should I also get rid of the |
Those are the same thing. The question is if there is any hardware that packs 80bit
Good point, might as well. Since I am pretty sure our build would fail anyway in other places if it existed in practice. |
Wouldn't that require |
hahahaha, sorry but it's funny :). |
Lol yea I knew about how it's secretly 80 bits. But I just thought that the padding was a consequence of the |
Alignment in memory. |
close/reopen |
Probably needs a rebase for CI. I can't right now, so feel free to do so if you feel like it |
Thanks Joren. |
Because
int256
,uint256
,float256
, andcomplex512
, aren't a thing 🤷.(first time I've touched the C code btw)