-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
TYP: generic StringDType
#28856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYP: generic StringDType
#28856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs some new typing tests too?
Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
It's all pretty straightforward so I didn't think it would be necessary to add additional tests for this. I figured that as long as the current type-tests involving Testing this would also be rather difficult because it involves But if you want to see some test either way, I won't mind adding some 🤷🏻 |
Eh, no worries. |
Thanks Joren. |
ported from numpy/numtype#335
This also adds the missing
na_object
andcoerce
kwargs toStringDType.__new__