MNT: Enforce ruff/flake8-bugbear rules (B) #28765

DimitriPapadopoulos · 2025-04-18T10:44:58Z

No description provided.

doc/neps/nep-0016-benchmark.py

numpy/_core/printoptions.py

numpy/_core/tests/test_deprecations.py

numpy/_core/tests/test_multiarray.py

numpy/lib/tests/test_function_base.py

numpy/ma/core.py

numpy/testing/_private/utils.py

tools/refguide_check.py

jorenham

I have the feeling that there are some threading subtleties that we might be missing here. Perhaps @ngoldbaum could also take a look at this?

numpy/_core/printoptions.py

DimitriPapadopoulos · 2025-04-19T17:54:51Z

Indeed, the underlying issue remains. I'm not familiar with ContextVar and cannot find a simple way to fix it. See Factory for contextvar default value.

ngoldbaum · 2025-04-19T21:13:54Z

I’ll try to take a look at this next week.

charris · 2025-04-25T19:18:47Z

Needs a rebase.

jorenham · 2025-04-28T16:48:09Z

this needs a rebase

numpy/testing/_private/utils.py

tools/refguide_check.py

jorenham

There's nothing left for me to complain about 👌🏻. So unless @ngoldbaum has any objections, this should be good to merge.

ngoldbaum · 2025-04-28T18:07:23Z

I think you need to do a little more to remove memusage, including in the type stubs, typing tests, and the __all__ for the numpy.testing._private.utils namespace.

DimitriPapadopoulos · 2025-04-29T07:19:19Z

I'm not sure why the compilation fails on Windows.

numpy/random/_pcg64.pyx compilation error

  [511/521] Compiling Cython source D:/a/1/s/numpy/random/_pcg64.pyx
  FAILED: numpy/random/_pcg64.cp312-win_amd64.pyd.p/numpy/random/_pcg64.pyx.c
  "cython" "-M" "--fast-fail" "-3" D:/a/1/s/numpy/random/_pcg64.pyx -o numpy/random/_pcg64.cp312-win_amd64.pyd.p/numpy/random/_pcg64.pyx.c
  [512/521] Compiling Cython source numpy/random/_generator.pyx
  [513/521] Compiling Cython source numpy/random/mtrand.pyx
  ninja: build stopped: subcommand failed.
  Activating VS 16.11.46
  INFO: automatically activated MSVC compiler environment
  INFO: autodetecting backend as ninja
  INFO: calculating backend command to run: C:\hostedtoolcache\windows\Python\3.12.10\x64\Scripts\ninja.EXE
  error: subprocess-exited-with-error
  
  Preparing metadata (pyproject.toml) did not run successfully.
  exit code: 1
  
  See above for output.
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  full command: 'C:\hostedtoolcache\windows\Python\3.12.10\x64\python.exe' 'C:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py' prepare_metadata_for_build_wheel 'C:\Users\VSSADM~1\AppData\Local\Temp\tmpxa2humy0'
  cwd: D:\a\1\s
  Preparing metadata (pyproject.toml): finished with status 'error'
error: metadata-generation-failed

Encountered error while generating package metadata.

ngoldbaum · 2025-04-29T13:50:57Z

That's odd, let's see if it's reproducible. I re-triggered the failed build.

numpy/testing/_private/utils.py

DimitriPapadopoulos · 2025-05-13T16:41:25Z

Rebased to fix conflicts.

DimitriPapadopoulos · 2025-05-13T16:50:16Z

I think B006 should be applied, especially in the public API. However, this is better left to a later PR, as some of the mutable arguments are used on purpose. I would nevertheless recommend fixing all occurrences, including those on purpose, even if the code is more verbose. For example:

def action(cache=[]):
    ...

should be changed to:

_cache = []

def action(cache=None):
    if cache is None:
        cache = _cache
    ...

I find the intent is easier to understand.

Using `hasattr(x, "__call__")` to test if x is callable is unreliable. Use `callable(x)` for consistent results.

Do not perform function call in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable In all these cases, the argument is designed to be persistent.

Do not assert blind exception: `Exception`

Found useless expression. Either assign it to a variable or remove it.

Loop control variable overrides iterable it iterates

abstract base class has no abstract methods or properties

Star-arg unpacking after a keyword argument is strongly discouraged

`except` handlers should only be exception classes or tuples of exception classes

Do not use mutable data structures for `ContextVar` defaults

B909 Mutation to loop iterable during iteration

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

The memusage function is only exercised in typing tests.

This reverts commit 371b363.

jorenham · 2025-05-15T23:43:33Z

Thanks Dimitri!

github-actions bot added the 03 - Maintenance label Apr 18, 2025

jorenham reviewed Apr 18, 2025

View reviewed changes

DimitriPapadopoulos force-pushed the B branch 2 times, most recently from 0b85500 to 6731f90 Compare April 18, 2025 18:37

jorenham reviewed Apr 19, 2025

View reviewed changes

numpy/_core/printoptions.py Show resolved Hide resolved

DimitriPapadopoulos force-pushed the B branch from 6731f90 to 81d24ab Compare April 27, 2025 09:58

jorenham reviewed Apr 28, 2025

View reviewed changes

numpy/testing/_private/utils.py Show resolved Hide resolved

jorenham reviewed Apr 28, 2025

View reviewed changes

tools/refguide_check.py Show resolved Hide resolved

jorenham approved these changes Apr 28, 2025

View reviewed changes

DimitriPapadopoulos force-pushed the B branch 2 times, most recently from 7e3940a to 741eb67 Compare April 28, 2025 17:26

DimitriPapadopoulos force-pushed the B branch 2 times, most recently from e1a7bb3 to 371b363 Compare April 28, 2025 22:02

ngoldbaum reviewed Apr 29, 2025

View reviewed changes

numpy/testing/_private/utils.py Outdated Show resolved Hide resolved

ngoldbaum approved these changes Apr 29, 2025

View reviewed changes

DimitriPapadopoulos force-pushed the B branch 2 times, most recently from 60c2e37 to 6c2bb69 Compare May 13, 2025 16:41

DimitriPapadopoulos added 4 commits May 15, 2025 09:29

STY: Apply ruff/flake8-bugbear rule B004

3fcdf41

Using `hasattr(x, "__call__")` to test if x is callable is unreliable. Use `callable(x)` for consistent results.

MNT: Apply ruff/flake8-bugbear rule B008

3b29e68

Do not perform function call in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable In all these cases, the argument is designed to be persistent.

MNT: Apply ruff/flake8-bugbear rule B017

c8f4881

Do not assert blind exception: `Exception`

MNT: Apply ruff/flake8-bugbear rule B018

0553a5a

Found useless expression. Either assign it to a variable or remove it.

DimitriPapadopoulos and others added 14 commits May 15, 2025 09:29

MNT: Apply ruff/flake8-bugbear rule B020

9488fa3

Loop control variable overrides iterable it iterates

MNT: Apply ruff/flake8-bugbear rule B024

8bb1f2a

abstract base class has no abstract methods or properties

MNT: Apply ruff/flake8-bugbear rule B026

15a4fa1

Star-arg unpacking after a keyword argument is strongly discouraged

MNT: Apply ruff/flake8-bugbear rule B030

4e9a159

`except` handlers should only be exception classes or tuples of exception classes

MNT: Apply ruff/flake8-bugbear B039

6c8912a

Do not use mutable data structures for `ContextVar` defaults

MNT: Apply ruff/flake8-bugbear rule B909

51c6169

B909 Mutation to loop iterable during iteration

MNT: Enforce ruff/flake8-bugbear rules (B)

18b06a5

MNT: Better solution for B008

daa3c57

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

MNT: Better solution for B020

4e48a1e

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

MNT: Better solution for B030

bfc040e

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

MNT: Better solution for B909

6559962

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

MNT: Fix new CI issue

ce3fb3c

MNT: get rid of dead code

a888681

The memusage function is only exercised in typing tests.

MNT: Revert "MNT: get rid of dead code"

6427409

This reverts commit 371b363.

DimitriPapadopoulos force-pushed the B branch from 6c2bb69 to 6427409 Compare May 15, 2025 07:33

jorenham merged commit 71faac1 into numpy:main May 15, 2025
74 checks passed

DimitriPapadopoulos deleted the B branch May 16, 2025 06:31

Uh oh!

MNT: Enforce ruff/flake8-bugbear rules (B) #28765

MNT: Enforce ruff/flake8-bugbear rules (B) #28765

Uh oh!

Conversation

DimitriPapadopoulos commented Apr 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jorenham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DimitriPapadopoulos commented Apr 19, 2025

Uh oh!

ngoldbaum commented Apr 19, 2025

Uh oh!

charris commented Apr 25, 2025

Uh oh!

jorenham commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

jorenham left a comment

Choose a reason for hiding this comment

Uh oh!

ngoldbaum commented Apr 28, 2025

Uh oh!

DimitriPapadopoulos commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngoldbaum commented Apr 29, 2025

Uh oh!

Uh oh!

DimitriPapadopoulos commented May 13, 2025

Uh oh!

DimitriPapadopoulos commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jorenham commented May 15, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

DimitriPapadopoulos commented Apr 29, 2025 •

edited

Loading

DimitriPapadopoulos commented May 13, 2025 •

edited

Loading