MAINT: update oldest supported GCC version from 8.4 to 9.3 #28102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hasn't been updated in quite a while, and 8.4 just ran into another SIMD-related bug in numpy#28030. Other considerations: - GCC 9.3.0 will be >5 years old by the time we release NumPy 2.3.0 - All our own builds and relevant manylinux images use GCC >=10 - SciPy upgraded to >=9.1 a year ago and that was fine - Ubuntu 20.04 LTS has GCC 9.3.0, there don't seem to be relevant distro versions which still require 8.x xref https://scipy.github.io/devdocs/dev/toolchain.html#compilers and https://github.com/mayeut/pep600_compliance for relevant pages to track compiler and distro versions.
|
Thanks @rgommers |
ArvidJB
added a commit
to ArvidJB/numpy
that referenced
this pull request
Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention and correctly split between argument type and documentation. Also update the `slice` release note to follow convention for new functions. Lastly, fix the gcc version upgrade PR reference from numpy#28101 to numpy#28102.
ArvidJB
added a commit
to ArvidJB/numpy
that referenced
this pull request
Jan 8, 2025
Update the `np.strings.slice` docstrings to follow convention and correctly split between argument type and documentation. Also update the `slice` release note to follow convention for new functions. Lastly, fix the gcc version upgrade PR reference from numpy#28101 to numpy#28102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been updated in quite a while, and 8.4 just ran into another SIMD-related bug in #28030. Other considerations:
xref https://scipy.github.io/devdocs/dev/toolchain.html#compilers and https://github.com/mayeut/pep600_compliance for relevant pages to track compiler and distro versions.