Skip to content

fix: only correct protocols when called from githost #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix: only correct protocols when called from githost #176

merged 1 commit into from
Oct 27, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Oct 26, 2022 •
edited
Loading

Now that hosted-git-info can be used to only parse a url, it should do so without treating any protocols in a special way. When called via hosted-git-info.fromUrl it will still pass in the object of preferred protocols, but when called via hosted-git-info.parseUrl it will accept all protocols, so that urls like file:../etc can be parsed.

Ref: npm/cli#5758

Also landing in v5 via #177.

@lukekarrys lukekarrys requested a review from a team as a code owner October 26, 2022 23:42
This was referenced Oct 26, 2022
Merged
Merged
Closed
@lukekarrys lukekarrys merged commit f03bfbd into main Oct 27, 2022
@lukekarrys lukekarrys deleted the lk/parse-all-protocols branch October 27, 2022 19:59
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Merged
@snyk-io snyk-io bot mentioned this pull request Sep 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @nlf
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy