Cannot box IsByRefLike type 'System.ReadOnlySpan'1' in Forms designer tests with 6.0
#14809
Comments
|
Standalone reproduction, Extract attached Repro14809.zip Expected output: 1 test failure. Actual output: NUnit Console Runner 3.9.0 Copyright (c) 2018 Charlie Poole, Rob Prouse |
|
Shorter repro, no nunit or msbuild. compile with using System;
using System.IO;
public class Repro14809 {
public static void Main ()
{
var a = new A ();
a.Test ();
}
}
public class A {
public A () {}
public void Test ()
{
var ad = MakeAD();
I i = (I)ad.CreateInstanceAndUnwrap (typeof (A).Assembly.FullName, nameof (T));
var w = i.GetWriter ();
w.WriteLine ("abcd");
}
public AppDomain MakeAD ()
{
return AppDomain.CreateDomain ("other domain");
}
}
public interface I {
TextWriter GetWriter ();
}
public class T : MarshalByRefObject, I {
public T () {
writer = TextWriter.Null; //Console.Out;
}
private TextWriter writer;
public virtual TextWriter GetWriter ()
{
return writer;
}
} |
|
This definitely worked in old versions. Do you need a bisect? |
|
@directhex yea, a bisect would be helpful. Although I have a sneaking suspicion the bisect will just point to #11111 which first implemented (Updated the repro - |
|
Interestingly, no, ab51a81 bisects good. |
|
I think it is the new ReadOnlySpan overloads in TextWriter xunit/xunit#1791 |
|
I expect it'll be some kind of big-ass CoreFX-related import, but have started a full bisect now. Will report in in the morning. |
|
@lewing Thanks! that's helpful. Looks like we can't make transparent proxies for any class that has a IsByRefLike argument. Trimmed down example coming soon. I think probably method-to-ir is throwing too eagerly when it is making a box in |
|
Even smaller standalone repro. The presence of using System;
public class Repro14809 {
public static void Main ()
{
var ad = AppDomain.CreateDomain ("other domain");
O o = (O)ad.CreateInstanceAndUnwrap (typeof (Repro14809).Assembly.FullName, nameof (Z));
Console.WriteLine ("{0}", o != null);
}
}
public ref struct MyByRefLikeStruct {}
public interface O {
void M1 (MyByRefLikeStruct s);
}
public class Z : MarshalByRefObject, O {
public Z () {}
public void M1 (MyByRefLikeStruct s) {}
} |
…truct arguments
If we have a ref struct and a method that takes it as an argument:
```
[Serializable]
public ref struct R {
public int i;
}
public interface I {
public void M1 (R r, SomeClass o);
}
public class M : MarshalByRefObject, I {
public void M1 (R r, SomeClass o) { ... }
}
```
If we create an instance of M in another domain and try to call it:
```
I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName,
nameof(M));
R r;
r.i = 42;
SomeClass o = ...;
obj.M1 (r, o);
```
Mono will need to create a wrapper that can invoke M.M1 in the other domain.
The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by
creating an array of all the arguments that need to be serialized (see
`mono_get_xdomain_marshal_type`) and then serializing the whole array (by
calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`).
In the example it would make a two element array and try to serialize `r` and
`o` into it. For valuetypes it normally does this by boxing the argument.
However since `R` is a ref-struct, boxing it is not allowed.
This works on .NET Framework.
However for Mono we would need to serilize `R` without boxing it, which seems
challenging with our current setup.
So for now we generate a wrapper that just throws a NotImplementedException if
it is ever called.
This fixes mono#14809 (in that marshalling a
TextWriter across domains works again) but in an unsatisfactory way (because
you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy
object).
…at take ref struct args Regression test for mono#14809
…truct arguments
If we have a ref struct and a method that takes it as an argument:
```
[Serializable]
public ref struct R {
public int i;
}
public interface I {
public void M1 (R r, SomeClass o);
}
public class M : MarshalByRefObject, I {
public void M1 (R r, SomeClass o) { ... }
}
```
If we create an instance of M in another domain and try to call it:
```
I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName,
nameof(M));
R r;
r.i = 42;
SomeClass o = ...;
obj.M1 (r, o);
```
Mono will need to create a wrapper that can invoke M.M1 in the other domain.
The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by
creating an array of all the arguments that need to be serialized (see
`mono_get_xdomain_marshal_type`) and then serializing the whole array (by
calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`).
In the example it would make a two element array and try to serialize `r` and
`o` into it. For valuetypes it normally does this by boxing the argument.
However since `R` is a ref-struct, boxing it is not allowed.
This works on .NET Framework.
However for Mono we would need to serilize `R` without boxing it, which seems
challenging with our current setup.
So for now we generate a wrapper that just throws a NotImplementedException if
it is ever called.
This fixes mono#14809 (in that marshalling a
TextWriter across domains works again) but in an unsatisfactory way (because
you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy
object).
…at take ref struct args Regression test for mono#14809
…truct arguments
If we have a ref struct and a method that takes it as an argument:
```
[Serializable]
public ref struct R {
public int i;
}
public interface I {
public void M1 (R r, SomeClass o);
}
public class M : MarshalByRefObject, I {
public void M1 (R r, SomeClass o) { ... }
}
```
If we create an instance of M in another domain and try to call it:
```
I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName,
nameof(M));
R r;
r.i = 42;
SomeClass o = ...;
obj.M1 (r, o);
```
Mono will need to create a wrapper that can invoke M.M1 in the other domain.
The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by
creating an array of all the arguments that need to be serialized (see
`mono_get_xdomain_marshal_type`) and then serializing the whole array (by
calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`).
In the example it would make a two element array and try to serialize `r` and
`o` into it. For valuetypes it normally does this by boxing the argument.
However since `R` is a ref-struct, boxing it is not allowed.
This works on .NET Framework.
However for Mono we would need to serilize `R` without boxing it, which seems
challenging with our current setup.
So for now we generate a wrapper that just throws a NotImplementedException if
it is ever called.
This fixes mono#14809 (in that marshalling a
TextWriter across domains works again) but in an unsatisfactory way (because
you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy
object).
…at take ref struct args Regression test for mono#14809
…truct arguments
If we have a ref struct and a method that takes it as an argument:
```
[Serializable]
public ref struct R {
public int i;
}
public interface I {
public void M1 (R r, SomeClass o);
}
public class M : MarshalByRefObject, I {
public void M1 (R r, SomeClass o) { ... }
}
```
If we create an instance of M in another domain and try to call it:
```
I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName,
nameof(M));
R r;
r.i = 42;
SomeClass o = ...;
obj.M1 (r, o);
```
Mono will need to create a wrapper that can invoke M.M1 in the other domain.
The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by
creating an array of all the arguments that need to be serialized (see
`mono_get_xdomain_marshal_type`) and then serializing the whole array (by
calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`).
In the example it would make a two element array and try to serialize `r` and
`o` into it. For valuetypes it normally does this by boxing the argument.
However since `R` is a ref-struct, boxing it is not allowed.
This works on .NET Framework.
However for Mono we would need to serilize `R` without boxing it, which seems
challenging with our current setup.
So for now we generate a wrapper that just throws a NotImplementedException if
it is ever called.
This fixes #14809 (in that marshalling a
TextWriter across domains works again) but in an unsatisfactory way (because
you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy
object).
…at take ref struct args Regression test for #14809
…f struct args (#14863) * [AppDomain] Cross-appdomain wrapper throws NIE for methods with ref struct arguments If we have a ref struct and a method that takes it as an argument: ``` [Serializable] public ref struct R { public int i; } public interface I { public void M1 (R r, SomeClass o); } public class M : MarshalByRefObject, I { public void M1 (R r, SomeClass o) { ... } } ``` If we create an instance of M in another domain and try to call it: ``` I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName, nameof(M)); R r; r.i = 42; SomeClass o = ...; obj.M1 (r, o); ``` Mono will need to create a wrapper that can invoke M.M1 in the other domain. The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by creating an array of all the arguments that need to be serialized (see `mono_get_xdomain_marshal_type`) and then serializing the whole array (by calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`). In the example it would make a two element array and try to serialize `r` and `o` into it. For valuetypes it normally does this by boxing the argument. However since `R` is a ref-struct, boxing it is not allowed. This works on .NET Framework. However for Mono we would need to serilize `R` without boxing it, which seems challenging with our current setup. So for now we generate a wrapper that just throws a NotImplementedException if it is ever called. This fixes #14809 (in that marshalling a TextWriter across domains works again) but in an unsatisfactory way (because you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy object). * [corlib] Add back Serializable attribute on some reflection classes Tests that use https://www.nuget.org/packages/NUnit.ApplicationDomain/ need to serialize MethodInfo (and hence MethodBase). * [corlib] Add test for transparent proxies for classes with methods that take ref struct args Regression test for #14809 * Bump API snapshot submodule
…ds with ref struct args (#14867) * [AppDomain] Cross-appdomain wrapper throws NIE for methods with ref struct arguments If we have a ref struct and a method that takes it as an argument: ``` [Serializable] public ref struct R { public int i; } public interface I { public void M1 (R r, SomeClass o); } public class M : MarshalByRefObject, I { public void M1 (R r, SomeClass o) { ... } } ``` If we create an instance of M in another domain and try to call it: ``` I obj = (I)otherDomain.CreateInstanceAndUnwrap (typeof(M).Assembly.FullName, nameof(M)); R r; r.i = 42; SomeClass o = ...; obj.M1 (r, o); ``` Mono will need to create a wrapper that can invoke M.M1 in the other domain. The way the wrapper works in `mono_marshal_get_xappdomain_invoke` is by creating an array of all the arguments that need to be serialized (see `mono_get_xdomain_marshal_type`) and then serializing the whole array (by calling out to `System.Runtime.Remoting.RemotingServices.SerializeCallData`). In the example it would make a two element array and try to serialize `r` and `o` into it. For valuetypes it normally does this by boxing the argument. However since `R` is a ref-struct, boxing it is not allowed. This works on .NET Framework. However for Mono we would need to serilize `R` without boxing it, which seems challenging with our current setup. So for now we generate a wrapper that just throws a NotImplementedException if it is ever called. This fixes #14809 (in that marshalling a TextWriter across domains works again) but in an unsatisfactory way (because you can't call any of the ReadOnlySpan<char> overloads on the transparent proxy object). * [corlib] Add back Serializable attribute on some reflection classes Tests that use https://www.nuget.org/packages/NUnit.ApplicationDomain/ need to serialize MethodInfo (and hence MethodBase). * [corlib] Add test for transparent proxies for classes with methods that take ref struct args Regression test for #14809 * Bump API snapshot submodule
|
@marek-safar Is there something more that needs to be done? It looks like it's been fixed everywhere. |
Changes: http://github.com/mono/mono/compare/2c3aeaf3780de7392a0d3cbe4dcf86846eb4dffa...29b1ac19c961b959a09097dbc0fe4cd567cc5298 $ git diff --shortstat 2c3aeaf3..29b1ac19 1528 files changed, 45421 insertions(+), 21967 deletions(-) Changes: mono/api-doc-tools@d03e819...5da8127 $ git diff --shortstat d03e8198..5da8127a 1001 files changed, 86168 insertions(+), 11863 deletions(-) Changes: mono/api-snapshot@e09042d...1ca8e82 $ git diff --shortstat e09042da..1ca8e82f 28 files changed, 612 insertions(+), 217 deletions(-) Changes: dotnet/cecil@a6c8f5e...cb6c1ca $ git diff --shortstat a6c8f5e1..cb6c1ca9 13 files changed, 233 insertions(+), 88 deletions(-) Changes: mono/corefx@4806207...470e0e1 $ git diff --shortstat 4806207f...470e0e10 4 files changed, 31 insertions(+), 12 deletions(-) Changes: dotnet/linker@ebe2a1f...1f87de3 $ git diff --shortstat ebe2a1f4...1f87de35 90 files changed, 3219 insertions(+), 1224 deletions(-) Changes: dotnet/java-interop@befdbc0...be6048e $ git diff --shortstat befdbc03...be6048ed 3 files changed, 3 insertions(+), 3 deletions(-) Upstream-Fixes: https://bugs.winehq.org/show_bug.cgi?id=47561 Upstream-Fixes: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25071 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25242 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25632 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25709 Upstream-Fixes: https://github.com/dotnet/corefx/issues/37955 Upstream-Fixes: https://github.com/dotnet/corefx/issues/38455 Upstream-Fixes: mono/mono#7377 Upstream-Fixes: mono/mono#8747 Upstream-Fixes: mono/mono#9621 Upstream-Fixes: mono/mono#9664 Upstream-Fixes: mono/mono#9706 Upstream-Fixes: mono/mono#10201 Upstream-Fixes: mono/mono#10645 Upstream-Fixes: mono/mono#10748 Upstream-Fixes: mono/mono#10848 Upstream-Fixes: mono/mono#12141 Upstream-Fixes: mono/mono#13311 Upstream-Fixes: mono/mono#13408 Upstream-Fixes: mono/mono#13412 Upstream-Fixes: mono/mono#13891 Upstream-Fixes: mono/mono#13923 Upstream-Fixes: mono/mono#13945 Upstream-Fixes: mono/mono#14170 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14215 Upstream-Fixes: mono/mono#14243 Upstream-Fixes: mono/mono#14377 Upstream-Fixes: mono/mono#14495 Upstream-Fixes: mono/mono#14555 Upstream-Fixes: mono/mono#14724 Upstream-Fixes: mono/mono#14729 Upstream-Fixes: mono/mono#14772 Upstream-Fixes: mono/mono#14792 Upstream-Fixes: mono/mono#14793 Upstream-Fixes: mono/mono#14809 Upstream-Fixes: mono/mono#14830 Upstream-Fixes: mono/mono#14839 Upstream-Fixes: mono/mono#14841 Upstream-Fixes: mono/mono#14847 Upstream-Fixes: mono/mono#14864 Upstream-Fixes: mono/mono#14871 Upstream-Fixes: mono/mono#14917 Upstream-Fixes: mono/mono#14945 Upstream-Fixes: mono/mono#14946 Upstream-Fixes: mono/mono#14948 Upstream-Fixes: mono/mono#14957 Upstream-Fixes: mono/mono#14959 Upstream-Fixes: mono/mono#14960 Upstream-Fixes: mono/mono#14961 Upstream-Fixes: mono/mono#14963 Upstream-Fixes: mono/mono#14971 Upstream-Fixes: mono/mono#14972 Upstream-Fixes: mono/mono#14975 Upstream-Fixes: mono/mono#15023 Upstream-Fixes: mono/mono#15048 Upstream-Fixes: mono/mono#15058 Upstream-Fixes: mono/mono#15080 Upstream-Fixes: mono/mono#15182 Upstream-Fixes: mono/mono#15188 Upstream-Fixes: mono/mono#15189 Upstream-Fixes: mono/mono#15261 Upstream-Fixes: mono/mono#15262 Upstream-Fixes: mono/mono#15263 Upstream-Fixes: mono/mono#15265 Upstream-Fixes: mono/mono#15268 Upstream-Fixes: mono/mono#15307 Upstream-Fixes: mono/mono#15324 Upstream-Fixes: mono/mono#15329 Upstream-Fixes: mono/mono#15330 Upstream-Fixes: mono/mono#15441 Upstream-Fixes: mono/mono#15446 Upstream-Fixes: mono/mono#15503 Upstream-Fixes: mono/mono#15541 Upstream-Fixes: mono/mono#15551 Upstream-Fixes: mono/mono#15556 Upstream-Fixes: mono/mono#15596 Upstream-Fixes: mono/mono#15691 Upstream-Fixes: mono/mono#15692 Upstream-Fixes: mono/mono#15740 Upstream-Fixes: mono/mono#15751 Upstream-Fixes: mono/mono#15760 Upstream-Fixes: mono/mono#15781 Upstream-Fixes: mono/mono#15794 Upstream-Fixes: mono/mono#15825 Upstream-Fixes: mono/mono#15853 Upstream-Fixes: mono/mono#15878 Upstream-Fixes: mono/mono#15887 Upstream-Fixes: mono/mono#15990 Upstream-Fixes: mono/mono#16032 Upstream-Fixes: mono/mono#16411 Upstream-Fixes: mono/mono#16486 Upstream-Fixes: https://github.com/mono/mono/issues/25709 Upstream-Fixes: https://github.com/mono/mono/issues/38821 Upstream-Fixes: #3112 Upstream-Fixes: #3168 Update `build-tools/automation/build.groovy` so that it fully cleans the build tree before starting the build, so that the vestigial mono submodule (removed in 0c9f83b) is *actually* removed from the build tree, so that we don't inadvertently use *ancient* submodule contents.
Changes: http://github.com/mono/mono/compare/2c3aeaf3780de7392a0d3cbe4dcf86846eb4dffa...29b1ac19c961b959a09097dbc0fe4cd567cc5298 $ git diff --shortstat 2c3aeaf3..29b1ac19 1528 files changed, 45421 insertions(+), 21967 deletions(-) Changes: mono/api-doc-tools@d03e819...5da8127 $ git diff --shortstat d03e8198..5da8127a 1001 files changed, 86168 insertions(+), 11863 deletions(-) Changes: mono/api-snapshot@e09042d...1ca8e82 $ git diff --shortstat e09042da..1ca8e82f 28 files changed, 612 insertions(+), 217 deletions(-) Changes: dotnet/cecil@a6c8f5e...cb6c1ca $ git diff --shortstat a6c8f5e1..cb6c1ca9 13 files changed, 233 insertions(+), 88 deletions(-) Changes: mono/corefx@4806207...470e0e1 $ git diff --shortstat 4806207f...470e0e10 4 files changed, 31 insertions(+), 12 deletions(-) Changes: dotnet/linker@ebe2a1f...1f87de3 $ git diff --shortstat ebe2a1f4...1f87de35 90 files changed, 3219 insertions(+), 1224 deletions(-) Changes: dotnet/java-interop@75b1189...4fd3539 $ git diff --shortstat 75b11891...4fd35393 34 files changed, 448 insertions(+), 52 deletions(-) Upstream-Fixes: https://bugs.winehq.org/show_bug.cgi?id=47561 Upstream-Fixes: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25071 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25242 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25632 Upstream-Fixes: https://github.com/dotnet/coreclr/issues/25709 Upstream-Fixes: https://github.com/dotnet/corefx/issues/37955 Upstream-Fixes: https://github.com/dotnet/corefx/issues/38455 Upstream-Fixes: mono/mono#7377 Upstream-Fixes: mono/mono#8747 Upstream-Fixes: mono/mono#9621 Upstream-Fixes: mono/mono#9664 Upstream-Fixes: mono/mono#9706 Upstream-Fixes: mono/mono#10201 Upstream-Fixes: mono/mono#10645 Upstream-Fixes: mono/mono#10748 Upstream-Fixes: mono/mono#10848 Upstream-Fixes: mono/mono#12141 Upstream-Fixes: mono/mono#13311 Upstream-Fixes: mono/mono#13408 Upstream-Fixes: mono/mono#13412 Upstream-Fixes: mono/mono#13891 Upstream-Fixes: mono/mono#13923 Upstream-Fixes: mono/mono#13945 Upstream-Fixes: mono/mono#14170 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14214 Upstream-Fixes: mono/mono#14215 Upstream-Fixes: mono/mono#14243 Upstream-Fixes: mono/mono#14377 Upstream-Fixes: mono/mono#14495 Upstream-Fixes: mono/mono#14555 Upstream-Fixes: mono/mono#14724 Upstream-Fixes: mono/mono#14729 Upstream-Fixes: mono/mono#14772 Upstream-Fixes: mono/mono#14792 Upstream-Fixes: mono/mono#14793 Upstream-Fixes: mono/mono#14809 Upstream-Fixes: mono/mono#14830 Upstream-Fixes: mono/mono#14839 Upstream-Fixes: mono/mono#14841 Upstream-Fixes: mono/mono#14847 Upstream-Fixes: mono/mono#14864 Upstream-Fixes: mono/mono#14871 Upstream-Fixes: mono/mono#14917 Upstream-Fixes: mono/mono#14945 Upstream-Fixes: mono/mono#14946 Upstream-Fixes: mono/mono#14948 Upstream-Fixes: mono/mono#14957 Upstream-Fixes: mono/mono#14959 Upstream-Fixes: mono/mono#14960 Upstream-Fixes: mono/mono#14961 Upstream-Fixes: mono/mono#14963 Upstream-Fixes: mono/mono#14971 Upstream-Fixes: mono/mono#14972 Upstream-Fixes: mono/mono#14975 Upstream-Fixes: mono/mono#15023 Upstream-Fixes: mono/mono#15048 Upstream-Fixes: mono/mono#15058 Upstream-Fixes: mono/mono#15080 Upstream-Fixes: mono/mono#15182 Upstream-Fixes: mono/mono#15188 Upstream-Fixes: mono/mono#15189 Upstream-Fixes: mono/mono#15261 Upstream-Fixes: mono/mono#15262 Upstream-Fixes: mono/mono#15263 Upstream-Fixes: mono/mono#15265 Upstream-Fixes: mono/mono#15268 Upstream-Fixes: mono/mono#15307 Upstream-Fixes: mono/mono#15324 Upstream-Fixes: mono/mono#15329 Upstream-Fixes: mono/mono#15330 Upstream-Fixes: mono/mono#15441 Upstream-Fixes: mono/mono#15446 Upstream-Fixes: mono/mono#15503 Upstream-Fixes: mono/mono#15541 Upstream-Fixes: mono/mono#15551 Upstream-Fixes: mono/mono#15556 Upstream-Fixes: mono/mono#15596 Upstream-Fixes: mono/mono#15691 Upstream-Fixes: mono/mono#15692 Upstream-Fixes: mono/mono#15740 Upstream-Fixes: mono/mono#15751 Upstream-Fixes: mono/mono#15760 Upstream-Fixes: mono/mono#15781 Upstream-Fixes: mono/mono#15794 Upstream-Fixes: mono/mono#15825 Upstream-Fixes: mono/mono#15853 Upstream-Fixes: mono/mono#15878 Upstream-Fixes: mono/mono#15887 Upstream-Fixes: mono/mono#15990 Upstream-Fixes: mono/mono#16032 Upstream-Fixes: mono/mono#16411 Upstream-Fixes: mono/mono#16486 Upstream-Fixes: https://github.com/mono/mono/issues/25709 Upstream-Fixes: https://github.com/mono/mono/issues/38821 Upstream-Fixes: dotnet#3112 Upstream-Fixes: dotnet#3168 Update `build-tools/automation/build.groovy` so that it fully cleans the build tree before starting the build, so that the vestigial mono submodule (removed in 0c9f83b) is *actually* removed from the build tree, so that we don't inadvertently use *ancient* submodule contents.
Changes: http://github.com/mono/mono/compare/2c3aeaf3780de7392a0d3cbe4dcf86846eb4dffa...29b1ac19c961b959a09097dbc0fe4cd567cc5298 $ git diff --shortstat 2c3aeaf3..29b1ac19 1528 files changed, 45421 insertions(+), 21967 deletions(-) Changes: mono/api-doc-tools@d03e819...5da8127 $ git diff --shortstat d03e8198..5da8127a 1001 files changed, 86168 insertions(+), 11863 deletions(-) Changes: mono/api-snapshot@e09042d...1ca8e82 $ git diff --shortstat e09042da..1ca8e82f 28 files changed, 612 insertions(+), 217 deletions(-) Changes: dotnet/cecil@a6c8f5e...cb6c1ca $ git diff --shortstat a6c8f5e1..cb6c1ca9 13 files changed, 233 insertions(+), 88 deletions(-) Changes: mono/corefx@4806207...470e0e1 $ git diff --shortstat 4806207f...470e0e10 4 files changed, 31 insertions(+), 12 deletions(-) Changes: dotnet/linker@ebe2a1f...1f87de3 $ git diff --shortstat ebe2a1f4...1f87de35 90 files changed, 3219 insertions(+), 1224 deletions(-) Changes: dotnet/java-interop@75b1189...4fd3539 $ git diff --shortstat 75b11891...4fd35393 34 files changed, 448 insertions(+), 52 deletions(-) Fixes: #3112 Fixes: #3168 Context: https://bugs.winehq.org/show_bug.cgi?id=47561 Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582 Context: https://github.com/dotnet/coreclr/issues/25071 Context: https://github.com/dotnet/coreclr/issues/25242 Context: https://github.com/dotnet/coreclr/issues/25632 Context: https://github.com/dotnet/coreclr/issues/25709 Context: https://github.com/dotnet/corefx/issues/37955 Context: https://github.com/dotnet/corefx/issues/38455 Context: mono/mono#7377 Context: mono/mono#8747 Context: mono/mono#9621 Context: mono/mono#9664 Context: mono/mono#9706 Context: mono/mono#10201 Context: mono/mono#10645 Context: mono/mono#10748 Context: mono/mono#10848 Context: mono/mono#12141 Context: mono/mono#13311 Context: mono/mono#13408 Context: mono/mono#13412 Context: mono/mono#13891 Context: mono/mono#13923 Context: mono/mono#13945 Context: mono/mono#14170 Context: mono/mono#14214 Context: mono/mono#14214 Context: mono/mono#14215 Context: mono/mono#14243 Context: mono/mono#14377 Context: mono/mono#14495 Context: mono/mono#14555 Context: mono/mono#14724 Context: mono/mono#14729 Context: mono/mono#14772 Context: mono/mono#14792 Context: mono/mono#14793 Context: mono/mono#14809 Context: mono/mono#14830 Context: mono/mono#14839 Context: mono/mono#14841 Context: mono/mono#14847 Context: mono/mono#14864 Context: mono/mono#14871 Context: mono/mono#14917 Context: mono/mono#14945 Context: mono/mono#14946 Context: mono/mono#14948 Context: mono/mono#14957 Context: mono/mono#14959 Context: mono/mono#14960 Context: mono/mono#14961 Context: mono/mono#14963 Context: mono/mono#14971 Context: mono/mono#14972 Context: mono/mono#14975 Context: mono/mono#15023 Context: mono/mono#15048 Context: mono/mono#15058 Context: mono/mono#15080 Context: mono/mono#15182 Context: mono/mono#15188 Context: mono/mono#15189 Context: mono/mono#15261 Context: mono/mono#15262 Context: mono/mono#15263 Context: mono/mono#15265 Context: mono/mono#15268 Context: mono/mono#15307 Context: mono/mono#15324 Context: mono/mono#15329 Context: mono/mono#15330 Context: mono/mono#15441 Context: mono/mono#15446 Context: mono/mono#15503 Context: mono/mono#15541 Context: mono/mono#15551 Context: mono/mono#15556 Context: mono/mono#15596 Context: mono/mono#15691 Context: mono/mono#15692 Context: mono/mono#15740 Context: mono/mono#15751 Context: mono/mono#15760 Context: mono/mono#15781 Context: mono/mono#15794 Context: mono/mono#15825 Context: mono/mono#15853 Context: mono/mono#15878 Context: mono/mono#15887 Context: mono/mono#15990 Context: mono/mono#16032 Context: mono/mono#16411 Context: mono/mono#16486 Context: https://github.com/mono/mono/issues/25709 Context: https://github.com/mono/mono/issues/38821 Update `build-tools/automation/build.groovy` so that it fully cleans the build tree before starting the build, so that the vestigial mono submodule (removed in 0c9f83b) is *actually* removed from the build tree, so that we don't inadvertently use *ancient* submodule contents.
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2734169
29 individual instances of:
@lambdageek
The text was updated successfully, but these errors were encountered: