Skip to content

Pass the full environment to the subprocess rather than just PYTHONPATH #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented Nov 16, 2020

Updated version of #79

@rdeits rdeits changed the title pass the full environment rather than just PYTHONPATH Pass the full environment to the subprocess rather than just PYTHONPATH Nov 16, 2020
@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #81 (73fd480) into master (7a63905) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   75.19%   75.21%   +0.02%     
==========================================
  Files          11       11              
  Lines        1024     1025       +1     
==========================================
+ Hits          770      771       +1     
  Misses        254      254              
Impacted Files Coverage Δ
src/meshcat/servers/zmqserver.py 32.14% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a63905...73fd480. Read the comment docs.

dcambie and others added 2 commits November 15, 2020 19:46
…riables and add PYTHONPATH to those

As suggested in https://www.scivision.dev/python-calling-python-subprocess/

At least PATH and SYSTEMROOT are necessary on windows to prevent the following error:
"Fatal Python error: _Py_HashRandomization_Init: failed to get random numbers to initialize Python"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy