Skip to content

Handle search for Liquid block hashes in search bar. #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

softsimon
Copy link
Member

fixes #797

This PR fixes the bug that it was impossible to search for a Liquid block hash. Liquid TXID, Block and Asset hashes follow the very same pattern.

Try searching with examples:

TXID
fcdf5012156207d1bc6d74a0402553bcfb87b206ebe2dd855ef387db11dd6e87
BLOCK HASH
c24d5201465d2107adb0d3bb7bd2aa750fdef47b5f3b7074409f630b2e938345
ASSET:
a0c358a0f6947864af3a06f3f6a2aeb304df7fd95c922f2f22d7412399ce7691

I am aware that the search component in general needs a full refactor, but the refactor could be in a separate PR, this one is just to fix this annoying bug.

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ bb07031

@wiz wiz merged commit 1f8ec2b into master Sep 25, 2021
@wiz wiz deleted the simon/liquid-block-hash-search-fix branch September 25, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Liquid: Search bar detects block hashes as transaction IDs
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy