-
Notifications
You must be signed in to change notification settings - Fork 790
Add option to display runestones and inscriptions metadata #5569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tentative concept ACK. I'll review the actual code in more depth later, but before we get too carried away with the implementation it might be worth discussing our end goals and the tradeoffs of different approaches: it seems to me there are four main options for getting and serving inscription/rune data:
calling out to an API wouldn't be very cypherpunk of us, and building our own would be a huge waste of effort, unless we're only interested in a very limited subset of data that wouldn't justify running a full Ord node. so we can probably rule out options 1 and 3. then the question is whether we expect to need anything that we can't easily get without Ord. off the top of my head, that probably includes:
stuff we can do without an index
stuff we can't do with Ord alone (unless it's changed recently)
so far the features from this PR seem achievable without Ord (and for unconfirmed transactions, maybe can't be done with Ord alone). but obviously if we plan to implement any of the features that do strictly require Ord in future, then we may as well start using it now. |
sorry for the essay :P |
Removed the need for the ord server: parsing of inscriptions and runestones is done client-side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace rune parsing libraries with minimal reimplementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK @ [65f080d]
Regarding
Please add a proper copyright notice, because you copied "substantial portions of the Software".
You are also invited to add the
This package has zero dependencies and should work without any additional configuration. |
This PR adds basic, optional support for displaying runestones and inscriptions details within a mempool instance.
Screen.Recording.2024-10-05.at.22.59.15.mov
Screen.Recording.2024-10-05.at.20.46.06.mov
Screen.Recording.2024-10-05.at.23.05.45.mov
No ord-related queries will be made unless the user specifically clicks on the 'Runestone' or 'Inscription' button.
This PR needs a
ord
server running withindex_runes
flag enabled.The mempool backend config should include the following, assuming the ord server runs on port 4321:
The frontend config needs the flag
"ORD": true
.