Skip to content

respect json Accept header in API error responses #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mononaut
Copy link
Collaborator

Upgrades all of our API error responses to use a new error handler, which checks the request Accept header and sends the error in the appropriate format (only supports json & plain text for now).

@mononaut mononaut requested review from wiz and softsimon August 22, 2024 19:58
@cla-bot cla-bot bot added the cla-signed label Aug 22, 2024
Copy link

cla-bot bot commented Sep 10, 2024

Thanks for your contribution to The Mempool Open Source Project. We require all contributors to agree to our Contributor License Agreement and don't seem to have one for you on file. Please see the instructions in CONTRIBUTING.md to proceed with this pull request.

@cla-bot cla-bot bot removed the cla-signed label Sep 10, 2024
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [75316e6]

@softsimon softsimon merged commit 8717051 into master Sep 13, 2024
12 of 13 checks passed
@softsimon softsimon deleted the mononaut/json-errors branch September 13, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy