Skip to content

display fee box skeleton while mempool not in sync #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2023

Conversation

mononaut
Copy link
Collaborator

@mononaut mononaut commented May 3, 2023

Displays the fee box skeleton loader when either the websocket is disconnected or the mempool is not in sync, to avoid showing bad fee estimates.

Before:
Screenshot 2023-05-03 at 2 45 51 PM

After:
Screenshot 2023-05-03 at 2 46 15 PM

@cla-bot cla-bot bot added the cla-signed label May 3, 2023
@softsimon softsimon self-requested a review May 9, 2023 20:44
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [65189d6]

@softsimon softsimon merged commit bfea535 into master May 14, 2023
@softsimon softsimon deleted the mononaut/skeleton-fee branch May 14, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy