Skip to content

Make sure we have initial channel stats to display after fresh run #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

nymkappa
Copy link
Member

@nymkappa nymkappa commented Jul 12, 2022

Depends on #2099

When you the lightning backend for the first time, you will not get anything display in the Channels Statistics widget.
This PR aims to insert the current channels stats in the last row of lightning_stats table (backfilled when running populateHistoricalStatistics function).

From a fresh install:

Master

Screen Shot 2022-07-12 at 8 01 23 PM

PR

Screen Shot 2022-07-12 at 8 04 46 PM

Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ v2.5.0-dev [19889712]

@softsimon softsimon merged commit c6f3331 into master Jul 14, 2022
@softsimon softsimon deleted the nymkappa/debug/insert-once-channels-stats-init branch July 14, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy