Use maxmind to store node locations #2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Tested ACK @ v2.5.0-dev [51949466]
root@localhost [mempool_mainnet_lightning]> select * from nodes where as_number = 397444 \G;
*************************** 1. row ***************************
public_key: 03db10aa09ff04d3568b0621750794063df401e6853c79a21a83e1a3f3b5bfb0c8
first_seen: 2021-08-01 08:18:16
updated_at: 2022-07-10 08:38:03
alias: ldk-ln-node.bitcoin.ninja
color: #000000
sockets: 69.59.18.80:9735,[2620:6e:a000:dead:0:babe:bad:cafe]:9735
as_number: 397444
city_id: 5128581
country_id: 6252001
accuracy_radius: 100
subdivision_id: 5128638
longitude: -73.9664
latitude: 40.7494
1 row in set (0.011 sec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only looks up and STORES location data for all the nodes.
New config option that defaults to disable:
New columns for the 'nodes' table is added and 1 new database table for the location info names are stored in a separate new table called geo_names.