frontend: Always reference resources relative to root
#2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db281b1 to
a895306
Compare
This patch was created by:
find ./frontend -type f -exec sed -i 's|\./resources|/resources|g' {} \;
a895306 to
355e89c
Compare
|
@erikarvstedt in the future can you please sign all commits? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the frontend references
resourcesvia relative URLs.Example:
./resources/bitcoin-logo.png, which resolves to/<lang>/resources/bitcoin-logo.pngfor non-default langs.Convert all of these instances to root-relative URLs (
/resources/bitcoin-logo.png).With this fix, the language-invariant
resourcedir no longer has to be copied to each lang dir, which shrinks the frontend size by 55% (279M -> 124M).Also, the nginx location config can be simplified.
Correctness
I've manually checked that relative
resourcesaccess no longer happens by logging browser requests.Also, searching the frontend for instances of string
resourcethat are not preceded by"/,'/or`/shows no offending results.Still, these checks might be incomprehensive, so the frontend requires further real-world testing before switching off copying of
resources.This patch is deployed at https://mempool.nixbitcoin.org