Use bitcoin core to fetch blocks #2039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces querying blocks through esplora vs bitcoin core when it is requested by users from the frontend.
In very rare occasion, it was possible for the user to query a block right before we index it. Since we were using esplora, the block was indexed on the fly in the db using an rounded difficulty (esplora bug). This created a follow up bug on the difficulty adjustments table.
Testing
/blocks
, confirm everything works fine, browse 6~7 pagesconfig.DATABASE.ENABLED: false
andMINING_DASHBOARD: false
(can still browse blocks, and see the blocks list)Note: Bisq and liquid are not be impacted because it uses a different code branch (the legacy /blocks backend code)