Move difficulty adjustment code to separate module #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the difficulty adjustment code in the frontend at all? |
I agree. This would be an useful API endpoint for mining service providers and miners. |
|
I suppose it just needs to be added to the websocket since the REST API endpoint exists at https://mempool.space/testnet/api/v1/difficulty-adjustment Did you want to close this PR and do that instead? I don't see why there is a totally duplicate implementation of the difficulty adjustment code in the frontend at all, unless there is some reason I am missing? @softsimon |
softsimon
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split difficulty adjustment code into a separate module so we can re-use it in the mining dashboard