Skip to content

User can drag the blockchain blocks horizontally with the mouse #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2021
Merged

User can drag the blockchain blocks horizontally with the mouse #1024

merged 1 commit into from
Dec 19, 2021

Conversation

nymkappa
Copy link
Member

Closes #907

Tested on Brave, Firefox and Safari (Desktop)
Test on DuckDuckGo and Safari (Mobile iOS)

ezgif-4-dedea358d7

Feature specs/checklist:

  • User can drag blocks with the followings actions: mousedown -> mousemove -> mouseup
  • When the mouse leaves the blocks container, drag does not stop
  • User can still click properly on blocks to inspect them (there is no conflict between the drag and click actions)
  • Disable all element selections events in the blocks container. When user move the mouse all over the page while dragging blocks, no element are selected.
  • It does not break mobile interactions

Feel free to update this checklist if you see anything else.
Thank you.

@nymkappa nymkappa requested a review from softsimon December 17, 2021 10:58
@nymkappa nymkappa requested a review from softsimon December 18, 2021 02:17
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK

@softsimon softsimon merged commit cec3bae into mempool:master Dec 19, 2021
@nymkappa nymkappa deleted the feature/blocks-mouse-scroll branch January 3, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a way to scroll the blocks chain to the right.
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy