feat: Added read_time as a parameter to various calls (async classes) #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
approved these changes
May 23, 2025
| @@ -20,6 +20,8 @@ | |||
| """ | |||
| from __future__ import annotations | |||
|
|
|||
| import datetime | |||
There was a problem hiding this comment.
nit: it looks like this can be in the TYPE_CHECKING block, since it's only needed for type annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PS is the async counterpart to #1050. It also fixes a slight system test flakiness issue with using Python generated datetime objects in one system test.
Fixes #775 for the async client.