fix: update the async transactional types to not require extra awaits #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b216867 to
ca23405
Compare
|
@wu-hui could I get a review here please? |
daniel-sanche
approved these changes
May 21, 2025
| @@ -41,6 +52,10 @@ | |||
| from google.cloud.firestore_v1.query_profile import ExplainOptions | |||
|
|
|||
|
|
|||
| T = TypeVar("T") | |||
| P = ParamSpec("P") | |||
There was a problem hiding this comment.
It looks like ParamSpec was added in python 3.10, and we need to support 3.8
There was a problem hiding this comment.
I added typing_extensions to support expanded type hinting for older python versions. Let me know if that works, otherwise I'll come up with something more hacky for the signatures.
There was a problem hiding this comment.
Sorry, adding an extra dependency to setup.py isn't an option unfortunately
Let me know if you're able to experiment with getting this working, or I can try to take it from here if you don't have the capacity
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the types of a few things in async_transactional to ensure that when a function wrapped with
@async_transactionalis called:the return type of the inner function is correctly detected as the correct final result by the typechecker
we can pass additional arguments to the wrapped function without the typechecker complaining
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #1044 🦕