Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

docs(samples): Various ways of creating a new disk #308

Merged
merged 15 commits into from
Aug 10, 2022
Merged

docs(samples): Various ways of creating a new disk #308

merged 15 commits into from
Aug 10, 2022

Conversation

m-strzelczyk
Copy link
Contributor

Will go to this doc site

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 27, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jul 27, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Jul 27, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 2, 2022
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@m-strzelczyk m-strzelczyk marked this pull request as ready for review August 3, 2022 12:52
@m-strzelczyk m-strzelczyk requested review from a team as code owners August 3, 2022 12:52
@m-strzelczyk m-strzelczyk requested a review from loferris August 3, 2022 12:52
parthea
parthea approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM

parthea
parthea reviewed Aug 6, 2022
View reviewed changes
savijatv
savijatv reviewed Aug 8, 2022
View reviewed changes
@m-strzelczyk m-strzelczyk merged commit d7b7825 into main Aug 10, 2022
@m-strzelczyk m-strzelczyk deleted the samples-disks branch August 10, 2022 13:47
@parthea parthea added the release-please:force-run To run release-please label Aug 10, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Aug 10, 2022
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@savijatv savijatv savijatv left review comments

@loferris loferris Awaiting requested review from loferris loferris was automatically assigned from googleapis/python-samples-reviewers

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-strzelczyk @parthea @savijatv @yoshi-kokoro @loferris
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy