Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

chore(samples): Making samples required for moving VM instance docs #242

Merged
merged 11 commits into from
Mar 23, 2022
Merged

chore(samples): Making samples required for moving VM instance docs #242

merged 11 commits into from
Mar 23, 2022

Conversation

m-strzelczyk
Copy link
Contributor

Working on samples for the Moving instance docs page

@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Mar 21, 2022
@snippet-bot
Copy link

snippet-bot bot commented Mar 21, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@m-strzelczyk m-strzelczyk changed the title Moving vm chore(samples): Making samples required for moving VM instance docs Mar 21, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 22, 2022
@m-strzelczyk m-strzelczyk marked this pull request as ready for review March 22, 2022 15:13
@m-strzelczyk m-strzelczyk requested review from a team as code owners March 22, 2022 15:13
parthea
parthea approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations, otherwise LGTM

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@m-strzelczyk m-strzelczyk merged commit 55f7361 into main Mar 23, 2022
@m-strzelczyk m-strzelczyk deleted the moving-vm branch March 23, 2022 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/python-compute API. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-strzelczyk @parthea
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy