refactor: define scalar expression structs #309
Conversation
4fd854c to
d9f34c9
Compare
| @@ -21,6 +21,9 @@ | |||
|
|
|||
| import bigframes.dtypes as dtypes | |||
|
|
|||
| if typing.TYPE_CHECKING: | |||
There was a problem hiding this comment.
Conditional import is discouraged. If have to do so, plz add a reason. go/pystyle#typing-conditional-imports
There was a problem hiding this comment.
Needed to avoid op->expression->op circular import. Generally op shouldn't depend on expression, but it is convenient to have a helper method to convert op to expression concisely. Added code comment explaining conditional is to avoid circular import
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import annotations |
There was a problem hiding this comment.
plz add docs for the file and for each of the classes. Abstractions are hard to understand.
There was a problem hiding this comment.
Added some docstrings
|
|
||
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class UnboundVariableExpression(Expression): |
There was a problem hiding this comment.
Means its a "free" variable. For instance, in the expression "x + y + 3/x", the variables "x" and "y" are unbound.
bigframes/core/compile/compiled.py
Outdated
| output_column_id: typing.Optional[str] = None, | ||
| ) -> T: | ||
| """Creates a new expression based on this expression with unary operation applied to one column.""" | ||
| ): |
There was a problem hiding this comment.
Docstring and type hint are omited?
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕