Skip to content

feat: add bpd.options.bigquery.requests_transport_adapters option #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add bpd.options.bigquery.requests_transport_adapters option #1755

wants to merge 2 commits into from

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 21, 2025 •
edited
Loading

This allows for overriding requests-based settings such as the maximum connection pool size.

Todos:

Fixes internal issue b/419106112 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 21, 2025
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2025
@tswast
Copy link
Collaborator Author

tswast commented May 21, 2025 •
edited
Loading

Wait for #1757 first. Done!

tswast added 2 commits May 21, 2025 13:07
@tswast
feat: add bpd.options.bigquery.requests_transport_adapters option
a610a63 
This allows for overriding requests-based settings such as the maximum
connection pool size.
@tswast
add unit test
409d91b
@tswast tswast force-pushed the b419106112-requests-transport-adapters branch from 426b763 to 409d91b Compare May 21, 2025 21:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 21, 2025
@tswast tswast marked this pull request as ready for review May 21, 2025 21:13
@tswast tswast requested review from a team as code owners May 21, 2025 21:13
@tswast tswast requested a review from sycai May 21, 2025 21:13
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2025
@tswast
Copy link
Collaborator Author

tswast commented May 22, 2025

test_credentials_need_reauthentication is a real failure. We no longer pass in a credentials object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai Awaiting requested review from sycai sycai is a code owner automatically assigned from googleapis/api-bigquery-dataframe

At least 1 approving review is required to merge this pull request.

Assignees

@TrevorBergeron TrevorBergeron

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @TrevorBergeron
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy