Skip to content

feat: initial langgraph checkpointer implementation #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

feat: initial langgraph checkpointer implementation #108

wants to merge 36 commits into from

Conversation

yeesian
Copy link
Collaborator

@yeesian yeesian commented Nov 1, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #107

@yeesian yeesian requested review from a team as code owners November 1, 2024 19:52
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label Nov 1, 2024
@yeesian
Copy link
Collaborator Author

yeesian commented Nov 1, 2024

/gcbrun

@yeesian yeesian marked this pull request as draft November 1, 2024 21:01
@kurtisvg
Copy link
Collaborator

kurtisvg commented Nov 4, 2024

@averikitsch FYI

@averikitsch
Copy link
Collaborator

/gcbrun

@averikitsch
Copy link
Collaborator

/gcbrun

@yeesian yeesian marked this pull request as ready for review November 5, 2024 00:51
@averikitsch
Copy link
Collaborator

/gcbrun

@yeesian
fix: separate the DDL statements into their own lines
a76b5da 
Otherwise we get
```
google.cloud.spanner_dbapi.exceptions.ProgrammingError: Executing DDL statements with executemany() method is not allowed.
```
@yeesian
fix: inline the table names into the DDL
7272dd0
@yeesian
Copy link
Collaborator Author

yeesian commented Nov 5, 2024

/gcbrun

yeesian added 18 commits November 5, 2024 02:15
@yeesian
fix: return the iterator in list()
347b03a
@yeesian
fix: connection in .list when yielding from a helper function
7cef58c
@yeesian
test: use pytest yield fixture
48184b0 
https://docs.pytest.org/en/6.2.x/fixture.html#yield-fixtures-recommended
@yeesian
chore: surface the DDLs to be class level constants
74ef9d1
@yeesian
feat: add ability to override table names
871cff0
@yeesian
chore(lint): silence mypy complaints
16dcb82
@yeesian
docs: add docstrings
9d04499
@yeesian
docs: add a notebook for LangGraph Checkpointer Usage
90719f4
@yeesian
docs: fix notebook urls
ba13efc
@yeesian
feat: update data type of values from STRING to JSON
fb90d68 
The bump in lowerbound for google-cloud-spanner is to capture the fix in googleapis/python-spanner#1236.
@yeesian
fix: update the logic for loading values from the database
dba9991
@yeesian
chore: remove unused references to serde
717020e
@yeesian
chore(lint): reorder the imports to pass isort checks
d3fd7b3
@yeesian
fix: serialization issue when loading JsonObject
affd167
@yeesian
chore(lint): fix type annotations
a2c8cc1
@yeesian
chore: update unit test values to JsonObject
cd67d02
@yeesian
chore(lint): used black to autoformat
42396e6
@yeesian
chore(lint): ignore mypy assignment errors
0e4b676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gauravpurohit06 gauravpurohit06

Labels
api: spanner Issues related to the googleapis/langchain-google-spanner-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LangGraph checkpointer implementation
5 participants
@yeesian @kurtisvg @averikitsch @rahul2393 @gauravpurohit06
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy