Skip to content

Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2017
Merged

Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. #3028

merged 2 commits into from
Feb 16, 2017

Conversation

daspecster
Copy link
Contributor

Updates 'google-cloud-core >= 0.23.0, < 0.24dev' dependencies in services.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2017
@daspecster daspecster mentioned this pull request Feb 15, 2017
Closed
3 tasks
dhermes
dhermes approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though this might be premature

@daspecster
Copy link
Contributor Author

Premature? This can wait if needed.

lukesneeringer
lukesneeringer reviewed Feb 16, 2017
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that all of the Client subclasses are sending the right arguments to super?

vision/setup.py Outdated
@@ -51,7 +51,7 @@

REQUIREMENTS = [
'enum34',
'google-cloud-core >= 0.22.1, < 0.23dev',
'google-cloud-core >= 0.23., < 0.24dev',

This comment was marked as spam.

Sign in to view

@daspecster
Copy link
Contributor Author

@lukesneeringer I haven't checked the clients. I feel like that should be a separate PR?

@lukesneeringer
Copy link
Contributor

@dhermes said (in an instant message) that it is already done.

@lukesneeringer
Copy link
Contributor

@dhermes Why is merging this premature? It seems reasonable to me.

@dhermes
Copy link
Contributor

dhermes commented Feb 16, 2017

Feel free to merge. No worries.

@daspecster daspecster merged commit 635f439 into googleapis:master Feb 16, 2017
@daspecster daspecster deleted the update-core-version-0.23.0 branch February 16, 2017 19:19
@dhermes dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (go…
6ce3507 
…ogleapis#3028)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
atulep pushed a commit that referenced this pull request Apr 3, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
3455b03 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
atulep pushed a commit that referenced this pull request Apr 18, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
3aaa558 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Jun 4, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
b4e9643 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Jul 6, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
4865602 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
abf496e 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
71416d9 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
4026523 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
parthea pushed a commit that referenced this pull request Oct 22, 2023
@daspecster
Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev. (#3028
7677e0c 
)

* Update core dependency to google-cloud-core >= 0.23.0, < 0.24dev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer left review comments

@dhermes dhermes dhermes approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspecster @lukesneeringer @dhermes @googlebot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy