Move dryRun property to from query to configuration level. #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll defer to @tseaver here |
tseaver
suggested changes
Feb 6, 2017
| @@ -31,7 +31,6 @@ class _SyncQueryConfiguration(object): | |||
| Values which are ``None`` -> server defaults. | |||
| """ | |||
| _default_dataset = None | |||
| _dry_run = None | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
bigquery/unit_tests/test_query.py
Outdated
| @@ -307,7 +307,6 @@ def test_run_w_alternate_client(self): | |||
| query.timeout_ms = 20000 | |||
| query.use_query_cache = False | |||
| query.use_legacy_sql = True | |||
| query.dry_run = True | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Feb 6, 2017
lukesneeringer
approved these changes
Feb 6, 2017
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…s#2984) * Move dryRun property to from query to configuration level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2981
Sets
dryRunat['configuration']['dryRun']rather than['configuration']['query']['dryRun].