chore: update volumes in lib-gen nightly CI #10470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
burkedavison
reviewed
Mar 5, 2024
Comment on lines
17
to
20
| if [[ $(docker volume inspect repo) != '[]' ]]; then | ||
| docker volume rm repo | ||
| fi | ||
| docker volume create --name "repo" --opt "type=none" --opt "device=$(pwd)" --opt "o=bind" | ||
| docker volume create --name "repo-google-cloud-java" --opt "type=none" --opt "device=$(pwd)" --opt "o=bind" |
There was a problem hiding this comment.
With this new name, should the above logic be updated?
There was a problem hiding this comment.
Ah, thanks for the catch. It indeed needs to be updated. Done.
JoeWang1127
approved these changes
Mar 5, 2024
Yes, I created googleapis/sdk-platform-java#2536 . Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test in progress: https://github.com/googleapis/google-cloud-java/actions/runs/8159602869/job/22304275554