fix: toolbox_agent bugs of date format #794
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When search hotels with some LLM, the date format shows as bellow ``` **Check-in Date:** April 23, 2024 ``` So i update the SQL in tools.yaml to be compatible with following instruction: ```sql update checkin date to 'April 24,2024' and checkout date to 'April 26,2024' of Best Western Bern ```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
seanzhou1023
approved these changes
May 21, 2025
|
thank you for the fix. but you need to go through CLA as a contributor. |
done
|
`samples/toolbox_agent`
seanzhou1023
approved these changes
May 23, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
May 23, 2025
-- 004eb36 by sudu <teric@outlook.com>: Update tools.yaml When search hotels with some LLM, the date format shows as bellow ``` **Check-in Date:** April 23, 2024 ``` So i update the SQL in tools.yaml to be compatible with following instruction: ```sql update checkin date to 'April 24,2024' and checkout date to 'April 26,2024' of Best Western Bern ``` -- 1300688 by qidu <qidu@outlook.com>: Fix the tools of `ToolboxToolset` initialization bugs for `samples/toolbox_agent` COPYBARA_INTEGRATE_REVIEW=#794 from qidu:main 5b3199d PiperOrigin-RevId: 762259287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Modify SQL in
samples/toolbox_agent/tools.yamlto process date format right.Date format
And the users maybe also update checkin or checkout date following this format.
tools.yamlto be compatible withsqlite3:Or the checkin or checkout date my be updated to
2024or0