Skip to content

Quantum: Add initial qltests for OpenSSL modeling #19564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bdrodes
Copy link
Contributor

@bdrodes bdrodes commented May 22, 2025

No description provided.

@github-actions github-actions bot added the C++ label May 22, 2025
}
}

class KnownOpenSSLSignatureAlgorithmConstant extends KnownOpenSSLAlgorithmConstant {

Check warning

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in KnownOpenSSLSignatureAlgorithmConstant should be PascalCase/camelCase.
//Heuristics for distinguishing int literals from other literals
exists(this.getValue().toInt()) and
not this instanceof CharLiteral and
not this instanceof StringLiteral

Check warning

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in isOpenSSLStringLiteralGenericSourceCandidate should be PascalCase/camelCase.
* Note: this predicate should only consider restrictions with respect to integers only.
* General restrictions are in the OpenSSLGenericSourceCandidateLiteral class.
*/
private predicate isOpenSSLIntLiteralGenericSourceCandidate(IntLiteral l) {

Check warning

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in isOpenSSLIntLiteralGenericSourceCandidate should be PascalCase/camelCase.
* Literals are filtered, for example, if they are used in a way no indicative of an algorithm use
* such as in an array index, bitwise operation, or logical operation.
* Note a case like this:
* if(algVal == "AES")

Check warning

Code scanning / CodeQL

Acronyms should be PascalCase/camelCase. Warning

Acronyms in OpenSSLGenericSourceCandidateLiteral should be PascalCase/camelCase.
@bdrodes bdrodes marked this pull request as ready for review May 22, 2025 20:15
@bdrodes bdrodes requested review from a team as code owners May 22, 2025 20:15
@jketema
Copy link
Contributor

jketema commented May 22, 2025

Just a quick drive-by comment: the tests should preferably go into the tests/experimental/library-tests sub-directory to match what is being done for the library itself.

@nicolaswill nicolaswill requested review from nicolaswill and removed request for a team May 22, 2025 22:14
@nicolaswill
Copy link
Contributor

Just a quick drive-by comment: the tests should preferably go into the tests/experimental/library-tests sub-directory to match what is being done for the library itself.

@jketema Would tests/library-tests/experimental/quantum/* also work? I do not have any preference, but we will need to update CODEOWNERS to specify whatever directory the tests eventually live in. If we use the structure I suggest, the existing CODEOWNERS entries should cover those test directories already.

@nicolaswill nicolaswill changed the title Initial openssl tests Quantum: Add initial qltests for OpenSSL modeling May 22, 2025
@jketema
Copy link
Contributor

jketema commented May 23, 2025

@nicolaswill How about changing the pattern in the code owners file to **/experimental/**/quantum/ @github/ps-codeql. I believe that should work?

@bdrodes bdrodes force-pushed the initial_openssl_tests branch 2 times, most recently from 3fc48eb to 5ab05cd Compare May 27, 2025 18:18
…ound through tests, and updating CODEOWNERS for quantum tests
@bdrodes bdrodes force-pushed the initial_openssl_tests branch from 5ab05cd to 41f008d Compare May 27, 2025 19:24
@nicolaswill
Copy link
Contributor

@jketema Ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy