-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Quantum: Add initial qltests for OpenSSL modeling #19564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
} | ||
|
||
class KnownOpenSSLSignatureAlgorithmConstant extends KnownOpenSSLAlgorithmConstant { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
//Heuristics for distinguishing int literals from other literals | ||
exists(this.getValue().toInt()) and | ||
not this instanceof CharLiteral and | ||
not this instanceof StringLiteral |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
* Note: this predicate should only consider restrictions with respect to integers only. | ||
* General restrictions are in the OpenSSLGenericSourceCandidateLiteral class. | ||
*/ | ||
private predicate isOpenSSLIntLiteralGenericSourceCandidate(IntLiteral l) { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
* Literals are filtered, for example, if they are used in a way no indicative of an algorithm use | ||
* such as in an array index, bitwise operation, or logical operation. | ||
* Note a case like this: | ||
* if(algVal == "AES") |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
Just a quick drive-by comment: the tests should preferably go into the |
@jketema Would |
@nicolaswill How about changing the pattern in the code owners file to |
3fc48eb
to
5ab05cd
Compare
…ound through tests, and updating CODEOWNERS for quantum tests
5ab05cd
to
41f008d
Compare
@jketema Ready for your review. |
No description provided.