Skip to content

Rust: upgrade rust-analyzer to 0.0.274 #19314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Rust: upgrade rust-analyzer to 0.0.274 #19314

wants to merge 21 commits into from

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Apr 15, 2025 •
edited
Loading

An outline of included work:

  • adapting crate_graph.rs to the underlying unstable API changes
  • updating the rust toolchains, as rust-analyzer requires that.
  • new rust-analyzer does not expand macros in ASTs that are expanded by attribute macros. Some effort was put into:
    • avoiding spamming on macro expansion warnings in the context of an item that needs to be expanded as an attribute macro, by turning off macro expansion in such a context
    • from the implementation point of view, this was achieved by renaming the special emit_detached into a more generic post_emit, and adding a corresponding pre_emit: this allows to do the above in terms of the pre_emit/post_emit pair for Item
    • tweaking the bad constructor query to work with this (looking into the expanded function bodies rather than the unexpanded ones).

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 15, 2025
@redsun82 redsun82 marked this pull request as ready for review April 15, 2025 16:10
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 16:10
@redsun82 redsun82 requested review from a team as code owners April 15, 2025 16:10
Copilot
Copilot AI reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 109 out of 129 changed files in this pull request and generated no comments.

Files not reviewed (20)
  • MODULE.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.android_system_properties-0.1.5.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anstyle-wincon-3.0.7.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.anyhow-1.0.98.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.argfile-0.2.1.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.atomic-0.6.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.borsh-1.5.7.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bstr-1.12.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bumpalo-3.17.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.bytemuck-1.22.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.byteorder-1.5.0.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.cc-1.2.19.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.chrono-0.4.40.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap-4.5.36.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.clap_builder-4.5.36.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.crossbeam-channel-0.5.15.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling-0.20.11.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_core-0.20.11.bazel: Language not supported
  • misc/bazel/3rdparty/tree_sitter_extractors_deps/BUILD.darling_macro-0.20.11.bazel: Language not supported

@redsun82 redsun82 requested a review from aibaars April 15, 2025 16:10
aibaars
aibaars previously approved these changes Apr 15, 2025
View reviewed changes
@aibaars aibaars force-pushed the redsun82/cargo-upgrade-2 branch 2 times, most recently from a85de02 to 5b76400 Compare April 18, 2025 10:30
@redsun82 redsun82 requested review from aibaars and geoffw0 May 19, 2025 12:19
geoffw0
geoffw0 reviewed May 19, 2025
View reviewed changes
rust/ql/src/queries/security/CWE-696/BadCtorInitialization.ql Outdated
or
// callable -> callable attribute macro expansion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment intended to be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, whoops, this was in a previous version I had, let me fix that, thanks!

@redsun82 redsun82 mentioned this pull request May 19, 2025
Draft
@redsun82 redsun82 requested a review from a team as a code owner May 19, 2025 15:23
@redsun82 redsun82 force-pushed the redsun82/cargo-upgrade-2 branch from a615ba1 to 5ec72b2 Compare May 19, 2025 15:24
geoffw0
geoffw0 reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL changes (src and tests) LGTM. 👍

update: oh, wait the spurious comment hasn't been deleted yet.

@redsun82
Copy link
Contributor Author

QL changes (src and tests) LGTM. 👍

update: oh, wait the spurious comment hasn't been deleted yet.

sorry, I was sure I had done it

@geoffw0
Copy link
Contributor

geoffw0 commented May 22, 2025

Extractor changes still need reviewing. I can do it if you're desperate / fairly confident / willing to answer basic questions.

@redsun82 redsun82 mentioned this pull request May 23, 2025
Merged
@redsun82
Copy link
Contributor Author

Extractor changes still need reviewing. I can do it if you're desperate / fairly confident / willing to answer basic questions.

At this point I would have you review the selected out commits in #19572

@redsun82 redsun82 marked this pull request as draft May 23, 2025 14:39
@redsun82 redsun82 force-pushed the redsun82/cargo-upgrade-2 branch from a1b66ff to 9a0f5af Compare May 26, 2025 10:36
@redsun82
Copy link
Contributor Author

obsoleted by #19524

@redsun82 redsun82 closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 left review comments

Copilot code review Copilot Copilot left review comments

@aibaars aibaars Awaiting requested review from aibaars

Assignees
No one assigned
Labels
documentation Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redsun82 @geoffw0 @aibaars
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy