adding behave test for data types #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
- Coverage 57.79% 57.78% -0.02%
==========================================
Files 195 195
Lines 26074 26074
Branches 855 855
==========================================
- Hits 15069 15066 -3
- Misses 9386 9387 +1
- Partials 1619 1621 +2 ☔ View full report in Codecov by Sentry. |
anthonylasso
approved these changes
May 21, 2024
| @@ -0,0 +1,24 @@ | |||
| Feature: Data within Featureform | |||
There was a problem hiding this comment.
pretty comprehensive. good stuff.
| @@ -13,7 +13,7 @@ def step_impl(context): | |||
| # Set the a unique variant prefix because we were running | |||
| # into an issue with behave tests running in parallel. This would | |||
| # cause the same variant to be generated for different tests. | |||
| context.unique_prefix = str(uuid.uuid4())[:5] | |||
| context.unique_prefix = str(uuid.uuid4())[:8].replace("-", "") | |||
There was a problem hiding this comment.
qq: why is the replace needed?
|
|
||
| @when("I can register a training set based on the feature and label") | ||
| def step_impl(context): | ||
| # TODO: Add unique name for training set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: