[v3-0-test] Port ti.run to Task SDK execution path (#50141)
#50980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last thing to remove the parallel execution path. For simplicity, `ti.run` and `ti._run_raw_task` have been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged: - `get_template_context`, - `handle_failure`, - `check_and_change_state_before_execution` - and probably a lot more. The following bugs/missing features were identified and implemented: - Running `on_kill` on the Task SDK execution path - Resolving lazy_object_proxies in the Context dict when running with a VirtualEnvOperator - apache#50898 (cherry picked from commit f1ca1d1)
ti.run to Task SDK execution path (#50141)ti.run to Task SDK execution path (#50141)
|
#protm : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last thing to remove the parallel execution path.
For simplicity,
ti.runandti._run_raw_taskhave been retained, but they now use the Task SDK execution path. They have been retained so we don't have to make big bang changes in tests and PR remains relatively review-able. There are opportunities for evaluating & cleanup after this PR is merged:get_template_context,handle_failure,check_and_change_state_before_executionThe following bugs/missing features were identified and implemented:
on_killon the Task SDK execution path(cherry picked from commit f1ca1d1)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.