Skip to content

Mask secrets when retrieving variables from secrets backend #50895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amoghrajesh
Copy link
Contributor

Follow up to this: #50880 (comment)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jroachgolf84
Copy link
Contributor

Does this mask ALL Variables retrieved from a Secrets Backend?

@amoghrajesh
Copy link
Contributor Author

@jroachgolf84 not all. Only the ones that are deemed sensitive.

@amoghrajesh amoghrajesh requested a review from uranusjr May 22, 2025 09:26
@amoghrajesh amoghrajesh added the backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch label May 22, 2025
@amoghrajesh amoghrajesh added this to the Airflow 3.0.2 milestone May 22, 2025
@amoghrajesh
Copy link
Contributor Author

@uranusjr could you take a look at this when you get some time?

@amoghrajesh amoghrajesh merged commit 98f9181 into apache:main May 23, 2025
71 checks passed
@amoghrajesh amoghrajesh deleted the mask-variables-for-secrets-backend branch May 23, 2025 07:46
github-actions bot pushed a commit that referenced this pull request May 23, 2025
…nd (#50895)

(cherry picked from commit 98f9181)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 23, 2025
…nd (apache#50895)

(cherry picked from commit 98f9181)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
kaxil pushed a commit that referenced this pull request May 23, 2025
…nd (#50895) (#50998)

(cherry picked from commit 98f9181)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:task-sdk backport-to-v3-0-test Mark PR with this label to backport to v3-0-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy