Skip to content

Add webserver config helm #50288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

peter-cheon
Copy link

Although the Helm chart's values.yaml allows configuration for webserverConfig,
there is no corresponding section in the api-server-deployment to apply this configuration.

As a result, even if webserverConfig is added—for example, for LDAP or other authentication settings—it is not properly applied.
To address this, we have added a manifest that includes the necessary configuration.

This update introduces conditional mounting of webserver configuration to the API server deployment. It ensures compatibility when `webserverConfig` or `webserverConfigConfigMapName` is specified. Additional logic for handling related volumes and volume mounts is included.
Corrected the indentation of the podAntiAffinity block in the api-server deployment YAML. This ensures proper configuration parsing and alignment with Kubernetes manifests formatting standards.
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 7, 2025
Copy link

boring-cyborg bot commented May 7, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@peter-cheon
Copy link
Author

@jedcunningham @hussein-awala @dstandish

Hello,
I know you have a busy schedule, but I would greatly appreciate it if you could take a moment to review the code above.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy