Skip to content

Fix node selections #50095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Fix node selections #50095

merged 1 commit into from
May 1, 2025

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented May 1, 2025

Fix a few bugs:

  • For "All Dag Dependencies" the dag node selection was broken (make sure to check dagId for isSelected)
  • If you had an asset and a dag with the same name, we would show both as selected (isSelected now checks asset:{id})
  • Cursor on an invalid asset ref made it look like it should be clickable (change cursor)

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@bbovenzi bbovenzi added this to the Airflow 3.0.1 milestone May 1, 2025
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 1, 2025
@bbovenzi bbovenzi merged commit 4ece2df into apache:main May 1, 2025
43 checks passed
@bbovenzi bbovenzi deleted the fix-node-selections branch May 1, 2025 22:32
kaxil pushed a commit that referenced this pull request May 6, 2025
(cherry picked from commit 4ece2df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy