You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
The reason will be displayed to describe this comment to others. Learn more.
Checking the services/ui/grid.py we have some get_task_group_children_getter there, which I think is supposed to do something similiar. Maybe there's something to fix there, I didn’t take a deep look yet ?
Checking the services/ui/grid.py we have some get_task_group_children_getter there, which I think is supposed to do something similiar. Maybe there's something to fix there, I didn’t take a deep look yet ?
Hi @pierrejeambrun , thanks for pointing this out, I've looked into the code, and it seems like the ordering in frontend relies from StructureDataResponse which are generated from get_combined_structure. Currently, get_combined_structure does not utilize get_task_group_children_getter which sets the proper sorting based on Airflow cfg. So, there is no issue with the get_task_group_children_getter function, it is just not utilized to generate the structure response. Let me utilize this function instead.
jsjasonseba
changed the title
Apply topological sort on task group grid
Apply task group sorting based on webserver config in grid structure response
Apr 18, 2025
…d structure response (#49418)
* Apply topological sort on task group grid
* Fix task_group sorting by utilizing get_task_group_children_getter to sort based on webserver config
* Adjust test expectation to sort children topologically
(cherry picked from commit d833ecb)
Co-authored-by: Jason <46563896+jsjasonseba@users.noreply.github.com>
…d structure response (#49418) (#50138)
* Apply topological sort on task group grid
* Fix task_group sorting by utilizing get_task_group_children_getter to sort based on webserver config
* Adjust test expectation to sort children topologically
(cherry picked from commit d833ecb)
Co-authored-by: Jason <46563896+jsjasonseba@users.noreply.github.com>
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
…response (apache#49418)
* Apply topological sort on task group grid
* Fix task_group sorting by utilizing get_task_group_children_getter to sort based on webserver config
* Adjust test expectation to sort children topologically
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #49374
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.