Update scheduler-deployment to cope with multiple executors #46039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jx2lee @jedcunningham This Pr is needed to finalize #43224 The metadata label in the scheduler deployment cannot contain a comma without being quoted and I found 1 occurrence that the previous PR #43606 did not cover. Hope this can be merged just in time for the helm chart 1.16 release |
romsharon98
approved these changes
Jan 26, 2025
|
@romsharon98 Added two tests. The first one doesn't really do what is expected since we mimic the rendering of the chart in a dict and strings are always quoted there. In the real world in yaml it could be unquoted but that is not testable in these tests. The other test fails if I remove my changes so that is a good addition. |
romsharon98
approved these changes
Jan 26, 2025
josix
pushed a commit
to josix/airflow
that referenced
this pull request
Jan 27, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Jan 30, 2025
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
2 tasks
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.