Refactor Slack API Hook and add new Connection type #25852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1632b4 to
f83d1ef
Compare
Taragolis
commented
Aug 21, 2022
| Examples: | ||
| .. code-block:: python | ||
| .. code-block:: python |
There was a problem hiding this comment.
This additional indent required to proper formatted block in documentation and PyCharm
Without additional space
https://airflow.apache.org/docs/apache-airflow-providers-slack/stable/_api/airflow/providers/slack/hooks/slack/index.html#airflow.providers.slack.hooks.slack.SlackHook
With additional space
Might be possible avoid this "hack"?
Taragolis
commented
Aug 21, 2022
Taragolis
commented
Aug 22, 2022
Comment on lines
180
to
+186
| def __get_token(self, token: Any, slack_conn_id: Any) -> str: | ||
| warnings.warn( | ||
| "`SlackHook.__get_token` method deprecated and will be removed in a future releases.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
Also might be better just remove this method.
It not used after changes and it is hardly possible that someone override it
Taragolis
commented
Aug 22, 2022
Comment on lines
+37
to
+43
| class ConnectionExtraConfig: | ||
| """Helper class for rom Connection Extra. | ||
|
|
||
| :param conn_type: Hook connection type. | ||
| :param conn_id: Connection ID uses for appropriate error messages. | ||
| :param extra: Connection extra dictionary. | ||
| """ |
There was a problem hiding this comment.
I create separate class for use in further steps
- Refactor
airflow.providers.slack.hooks.slack_webhook.SlackWebhookHookwhich mostly designed for use with legacy Slack Integrations - Create new hook and connection which will use
slack_sdk.webhook.WebhookClientand create integration with Slack Incoming Webhook based on Slack API/App
eb00fb8 to
ed8a940
Compare
ed8a940 to
7ae8172
Compare
potiuk
approved these changes
Aug 31, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Slack API hook
__init__methodtokenin Hook argument. IMHO, there is not a good idea provide directly token better to use Connection.Connection UI and Testing Connection